]> dgit.raspbian.org Git - gnome-shell.git/commit
slider: Use the sprite of the touch event, not the pointer
authorDaniel van Vugt <daniel.van.vugt@canonical.com>
Tue, 23 Sep 2025 06:12:56 +0000 (14:12 +0800)
committerDaniel van Vugt <daniel.van.vugt@canonical.com>
Tue, 23 Sep 2025 06:18:54 +0000 (14:18 +0800)
commite54aa588c1604b63e2f051e20c1ecb3e601beb5c
tree6947e6b85e73adab78205cb78558dcd7964bf62b
parentc66a2583ebfc2d4341d8e530a11dfc53128f9aa5
slider: Use the sprite of the touch event, not the pointer

startDragging() starts with:

  const sprite = backend.get_sprite(global.stage, event);
  this._sprite = sprite;

but then vfunc_touch_event() would only compare this._sprite to:

  sprite = backend.get_pointer_sprite(global.stage);

which never matched. And so _endDragging() was never called and
the grab was never dismissed, effectively freezing the shell.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/8660
Fixes: c206ec693 ("slider: Use Clutter.Sprite for pointing focus accounting")
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3887>
js/ui/slider.js